-
-
Notifications
You must be signed in to change notification settings - Fork 297
Fix MastodonSDK package tests #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix MastodonSDK package tests #1498
Conversation
…DK to fix build warning
…estplan reference
|
This change does not address |
whattherestimefor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo in that one function name.
Thanks!
| func testCreateAnAnpplication() throws { | ||
| try _testCreateAnAnpplication(domain: domain) | ||
| func testCreateAnAnpplication() async throws { | ||
| try await _testCreateAnAnpplication(domain: domain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? _testCreateAnAnpplication -> _testCreateAnApplication
| func _testCreateAnAnpplication(domain: String) throws { | ||
| let theExpectation = expectation(description: "Create An Application") | ||
|
|
||
| func _testCreateAnAnpplication(domain: String) async throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same typo
Description
./MastodonSDK/Tests/MastodonSDKTestswere previously failing to build./MastodonSDK/Package.swiftor through Mastodon.xcodeprojPlease note that the tests still fail when ran for testing, but the sources compile successfully for testing.
Screenshots
Adding MastodonSDK.xctestplan to Mastodon.xcodeproj > Mastodon scheme > Testing action
Previous build warning about MastodonSDKTests missing dependencies that are fixed in this PR